The old Preference::tryUISubmit() and the new submitForm() would
blissfully return Status::newGood(), even when it isn't good.
Bug: T191933
Change-Id: I4e35c5a71800f88b2063dd0361d83a56f54d58c3
protected function submitForm( array $formData, PreferencesForm $form ) {
$res = $this->saveFormData( $formData, $form );
- if ( $res ) {
+ if ( $res === true ) {
$context = $form->getContext();
-
$urlOptions = [];
if ( $res === 'eauth' ) {
$context->getOutput()->redirect( $url );
}
- return Status::newGood();
+ return ( $res === true ? Status::newGood() : $res );
}
/**